Brussels | ITP-2026-1 | James Ishimwe | Sprint 3 | Coursework/sprint 3#81
Open
jamesishimwe wants to merge 61 commits intoHackYourFutureBelgium:mainfrom
Open
Brussels | ITP-2026-1 | James Ishimwe | Sprint 3 | Coursework/sprint 3#81jamesishimwe wants to merge 61 commits intoHackYourFutureBelgium:mainfrom
jamesishimwe wants to merge 61 commits intoHackYourFutureBelgium:mainfrom
Conversation
jamesishimwe
changed the title
noahg9
reviewed
Apr 30, 2026
| } | ||
| } else if (numberCards.includes(rank)) return Number(rank); | ||
| else if (otherCards.includes(rank)) return 10; | ||
| else return "Invalid Card"; |
There was a problem hiding this comment.
You should throw an error instead of returning a string (and then update the tests at the bottom)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brussels | ITP-2026-1 | James Ishimwe | Sprint 3 | Coursework/sprint 3
Complete the self checklist - replace each empty box in the checklist [ ] with a [x].
Add the label "Needs Review" and you will get review.
Respond to volunteer reviews until the volunteer marks it as "Complete".
-->
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
I have implemented functions and wrote tests to check different scenarios.